Hashim1999164 opened a new pull request, #5129: URL: https://github.com/apache/datafusion-comet/pull/5129
## Which issue does this PR close? Closes #5088. ## Rationale for this change Arrow 58 exposes `arrow::array::timezone::Tz` when the existing `chrono-tz` feature is enabled. Keeping a copied implementation in `spark-expr` creates two parallel timezone types and duplicates upstream code. ## What changes are included in this PR? - replace the local timezone type in string, temporal, and utility code with Arrow's public `Tz` - remove the copied `timezone.rs` module - remove the now-unused direct `chrono-tz` dependency from `spark-expr` ## How are these changes tested? - `cargo test -p datafusion-comet-spark-expr --lib` (538 passed) - `cargo clippy -p datafusion-comet-spark-expr --all-targets -- -D warnings` - `cargo fmt --all -- --check` No new tests are needed because this is a type substitution with equivalent parsing behavior, and the existing timezone, fixed-offset, DST, and timestamp parsing tests exercise the affected paths. ## AI assistance AI assistance was used to locate consumers of the copied type and draft the mechanical import substitutions. I reviewed the full diff and ran the validation above. Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
