huaxingao commented on code in PR #802:
URL: https://github.com/apache/datafusion-comet/pull/802#discussion_r1714242861
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -1277,8 +1277,6 @@ impl PhysicalPlanner {
}
AggExprStruct::Min(expr) => {
let child = self.create_expr(expr.child.as_ref().unwrap(),
schema.clone())?;
- let datatype =
to_arrow_datatype(expr.datatype.as_ref().unwrap());
- let child = Arc::new(CastExpr::new(child, datatype.clone(),
None));
Review Comment:
This is not related to window function `sum` support.
`CastExpr` is not needed for min and max, so remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
