buraksenn commented on code in PR #23917:
URL: https://github.com/apache/datafusion/pull/23917#discussion_r3666796178
##########
datafusion/common/src/utils/hex.rs:
##########
@@ -72,6 +74,44 @@ impl HexCase {
}
}
+/// Trait for converting integer types to hexadecimal in a buffer
+pub trait ToHex: ArrowNativeType {
Review Comment:
Since `ArrowNativeType` is already sealed ToHex is effectively sealed as
well. Maybe we can make it sealed to show this explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
