Omega359 commented on code in PR #11942:
URL: https://github.com/apache/datafusion/pull/11942#discussion_r1714181648
##########
datafusion/functions/src/unicode/rpad.rs:
##########
@@ -46,8 +48,11 @@ impl RPadFunc {
signature: Signature::one_of(
vec![
Exact(vec![Utf8, Int64]),
+ Exact(vec![Utf8View, Int64]),
Exact(vec![LargeUtf8, Int64]),
Exact(vec![Utf8, Int64, Utf8]),
+ Exact(vec![Utf8View, Int64, Utf8]),
+ Exact(vec![Utf8View, Int64, Utf8View]),
Review Comment:
Given the possible signatures I would think so. An example I can come up
with is populating the different args from a table that have different column
types, one being utf8 and another being utf8view. Not standard, no, but
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
