Omega359 commented on code in PR #11942:
URL: https://github.com/apache/datafusion/pull/11942#discussion_r1713789099
##########
datafusion/functions/src/unicode/rpad.rs:
##########
@@ -46,8 +48,11 @@ impl RPadFunc {
signature: Signature::one_of(
vec![
Exact(vec![Utf8, Int64]),
Review Comment:
As noted in https://github.com/apache/datafusion/pull/11924/files::
// Planner attempts coercion to the target type starting with the most
preferred candidate.
// For example, given input `(Utf8View, Utf8)`, it first tries coercing to
`(Utf8View, Utf8View)`.
// If that fails, it proceeds to `(Utf8, Utf8)`.
Thus, the ordering of the signature should likely be changed to reflect that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
