maxburke commented on PR #23032: URL: https://github.com/apache/datafusion/pull/23032#issuecomment-5093751302
> > @mbutrovich @Dandandan What is the status of this PR from a Datafusion point of view? Is there concrete action that needs to be taken to get it into mergable shape? Or is it unacceptable for Datafusion? > > edit: if it's unacceptable I'd rather be told that so I can move on. If it needs work I'd like to know what work needs to be done so that I can start on that. It's this limbo state that's frustrating. > > I don't believe this is acceptable until a deeper performance analysis is performed. As it currently stands, it raises a legitimate performance concern, but I am not convinced that the solution is not over-specialized to your use case. DataFusion needs to remain generally performant, and there are too many open questions in my previous comment that have not been explored. Does performance really matter if it isn't correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
