wangzhigang1999 commented on code in PR #23718:
URL: https://github.com/apache/datafusion/pull/23718#discussion_r3656777076
##########
datafusion/spark/src/function/string/format_string.rs:
##########
@@ -2896,17 +2900,26 @@ mod tests {
#[test]
fn test_grouping_separator_parentheses_decimal() -> Result<()> {
- // %(,15.2f on negative decimal — format_decimal ignores
negative_in_parentheses,
- // always uses '-'. Check TODO in fn format_decimal
+ test_scalar_function!(
Review Comment:
Good point, thanks! I added an equivalent Decimal256 regression case in
0d51a2c, so both public decimal scalar variants are now covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
