github-actions[bot] commented on PR #23915: URL: https://github.com/apache/datafusion/pull/23915#issuecomment-5087520540
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v54.1.0 (current) Built [ 37.668s] (current) Parsing datafusion-physical-plan v54.1.0 (current) Parsed [ 0.140s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 38.173s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.141s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.650s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_physical_plan::proto::ExecutionPlanDecode::decode_plan_with_scalar_subquery_results in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/proto.rs:108 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 78.025s] datafusion-physical-plan Building datafusion-proto v54.1.0 (current) Built [ 59.774s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 59.824s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.229s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_marked_deprecated: trait method #[deprecated] added --- Description: A trait method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_marked_deprecated.ron Failed in: method try_into_scalar_subquery_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:664 method try_from_scalar_subquery_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:664 Summary semver requires new minor version: 0 major and 1 minor checks failed Finished [ 121.351s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
