andygrove commented on code in PR #811:
URL: https://github.com/apache/datafusion-comet/pull/811#discussion_r1713770493
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2501,6 +2501,13 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
case SortExec(sortOrder, _, child, _)
if isCometOperatorEnabled(op.conf, CometConf.OPERATOR_SORT) =>
+ // TODO: Remove this constraint when we upgrade to new arrow-rs
including
+ // https://github.com/apache/arrow-rs/pull/6225
+ if (child.output.length == 1 &&
child.output.head.dataType.isInstanceOf[StructType]) {
Review Comment:
As we add support for other types, do we need to update this to make it
recursive so that we check for Map or Array containing struct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
