unikdahal commented on PR #4658: URL: https://github.com/apache/datafusion-comet/pull/4658#issuecomment-5079461504
Hi @jordepic, Not sure if this is the right place to ask this, and I'm fairly new to Comet so I may well have misread something. We're in the middle of migrating to Comet, and most of our Iceberg writes are `CREATE OR REPLACE TABLE ... AS SELECT` rather than INSERT INTO or INSERT OVERWRITE. Since this PR is about which write commands get split into writer + committer, I noticed RTAS/CTAS isn't one of them. Looks to me like the issue is timing rather than the split itself? `IcebergWriteExec` takes `batchWrite` in the constructor so it's bound at planning time, but RTAS stages the table inside `run()`. Does that rule out adding it later, or could it be late-bound, since `IcebergCommitExec.run()` is already the thing that drives the child through `executeCollect()`? Not asking for it here, the PR is clearly better off staying as is. Mostly just want to know if the follow-up is straightforward. Happy to pick it up if no one else is on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
