andygrove commented on code in PR #4991:
URL: https://github.com/apache/datafusion-comet/pull/4991#discussion_r3638658134
##########
native/proto/src/proto/operator.proto:
##########
@@ -277,6 +282,13 @@ message IcebergDeleteFile {
// Equality field IDs (empty for positional deletes)
repeated int32 equality_ids = 4;
+
+ // Serialized StandardKeyMetadata for an encrypted delete file, from
DeleteFile.keyMetadata().
+ // Absent for unencrypted tables. Decoded directly by iceberg-rust; no KMS
unwrap needed.
+ // Field 8: fields 5-7 are reserved for the deletion-vector coordinates on
the dv-read branch
Review Comment:
Should we add an explicit `reserved 5, 6, 7` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
