timsaucer commented on code in PR #23703: URL: https://github.com/apache/datafusion/pull/23703#discussion_r3637748233
########## datafusion/session/src/catalog.rs: ########## @@ -0,0 +1,246 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: Correct! With this and the next PR that will build on this one, `datafusion-session` is becoming more of a `datafusion-api` where the interacting traits are all defined and then things like `datafusion-catalog` will have the concrete implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
