zhuqi-lucas commented on PR #23523: URL: https://github.com/apache/datafusion/pull/23523#issuecomment-5054399402
Follow-up on @kosiew's FSL<Dict> catch: filed the upstream fix for the underlying arrow-row bug. - Issue: https://github.com/apache/arrow-rs/issues/10413 — `decode_fixed_size_list` skips the `corrected_type` step, causes `FixedSizeList<Dictionary<K, V>>` (and any type containing one) to fail `convert_rows` with `InvalidArgumentError`. - Fix PR: https://github.com/apache/arrow-rs/pull/10414 — adopts the same `corrected_type` shape the other list-like decoders (`List`, `LargeList`, `ListView`, `LargeListView`, `Map`) already use. ~10 line change + regression test in `arrow-row`. Once that merges and we bump the `arrow-row` dep here, the `contains_fsl_with_dictionary` blacklist in this PR can be removed in a one-line follow-up. The `contains_union_or_run_end_encoded` blacklist is independent — it stays until we add explicit round-trip coverage for those families here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
