andygrove commented on PR #23766: URL: https://github.com/apache/datafusion/pull/23766#issuecomment-5049352173
Filed the follow-ons: - #23810 — avoid the per-row `String` allocation in `md5` / `sha1` / `sha2`, and drop `encode_bytes` once its callers no longer need it. Covers both the `hex.rs` and `md5.rs` comments, since they are the same fix at different call sites. - #23811 — whether `to_hex`'s Arrow integer type dispatch should move into `datafusion-common` too. I wrote up the case against as well as for: the widening rules are the part most likely to want per-dialect variation, so it may reasonably close as working-as-intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
