naman-modi commented on PR #23789: URL: https://github.com/apache/datafusion/pull/23789#issuecomment-5042421380
Hey @kosiew, can you please review this PR, when you get a chance? One small design note: I went with a small `UnparserAggScope` struct that holds the aggregate and the "is the input a derived subquery" flag, computed once and reused by every clause, rather than a bare helper fn taking the flag as a parameter. IMO, it reads a bit cleaner at the call sites and keeps the flag from being recomputed per clause. If you'd rather keep it consistent with the existing `impl Unparser` helpers, I'm happy to drop the struct and move it to a plain associated fn instead. TIA! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
