sgrebnov commented on code in PR #23677: URL: https://github.com/apache/datafusion/pull/23677#discussion_r3618053625
########## datafusion/physical-optimizer/src/output_requirements.rs: ########## Review Comment: Great catch - improved. A second `Add` pass descended past the existing wrapper and stamped a redundant empty one on top. The helper now treats an existing `OutputRequirementExec` as already-handled (`is_changed = true`) and stops. Added `add_mode_is_idempotent_on_scalar_subquery` test - passes with the fix now (existing idempotency tests only covered root wrappers). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
