peterxcli commented on PR #4898: URL: https://github.com/apache/datafusion-comet/pull/4898#issuecomment-5020270838
> The codegen output uses Math.multiplyExact(micros, 1000L), which throws on overflow, while the ArrowWriter path relies on Spark's writer, which multiplies without the exact check. For an interval whose microseconds exceed what Arrow's int64 nanoseconds can hold, one path throws and the other wraps. Worth a short comment on the intended behavior for that (rare) case. Seems like `ArrowWriter` use `Math.multiplyExact`, too. I think, so they're actually consistent on the overflow exception. https://github.com/apache/datafusion-comet/blob/155e7321e95650dac01e6c1fb51cbc433e114b30/spark/src/main/scala/org/apache/spark/sql/comet/execution/arrow/ArrowWriters.scala#L497-L506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
