phillipleblanc commented on code in PR #2088:
URL:
https://github.com/apache/datafusion-ballista/pull/2088#discussion_r3609654628
##########
ballista/executor/src/executor_process.rs:
##########
@@ -126,6 +128,8 @@ pub struct ExecutorProcessConfig {
pub port: u16,
/// Port for the executor's gRPC service.
pub grpc_port: u16,
+ /// Port for the executor's HTTP health server (`/healthz` and `/readyz`).
+ pub health_port: u16,
Review Comment:
@avantgardnerio no problem! Originally Ballista was started as a standalone
binary process, and it was relatively recently that @milenkovicm started to
focus it to be more of a library (which is one of the reasons we decided to go
with Ballista rather than something like
[`datafusion-distributed`](https://github.com/datafusion-contrib/datafusion-distributed)
which is also a library, but has different design goals)
I agree that putting the health APIs on the scheduler rest API make sense.
Everything else looks good now, thanks for reworking this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
