phillipleblanc commented on code in PR #2088:
URL:
https://github.com/apache/datafusion-ballista/pull/2088#discussion_r3606748576
##########
ballista/executor/src/executor_process.rs:
##########
@@ -126,6 +128,8 @@ pub struct ExecutorProcessConfig {
pub port: u16,
/// Port for the executor's gRPC service.
pub grpc_port: u16,
+ /// Port for the executor's HTTP health server (`/healthz` and `/readyz`).
+ pub health_port: u16,
Review Comment:
In our project we embed Ballista in our process that already defines
health/readiness probes that are specific to our implementation. This would add
a second health surface that we can't turn off without removing this code in
our fork.
Perhaps similar to the `rest-api` feature flag, we could add a
`health-probes` flag that controls this? (or bundle this with the `rest-api`
feature flag?) Alternatively a separate option to control whether ballista
starts the health service at all that we could disable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
