mbutrovich commented on code in PR #4892:
URL: https://github.com/apache/datafusion-comet/pull/4892#discussion_r3574202917
##########
spark/src/main/scala/org/apache/comet/rules/EliminateRedundantTransitions.scala:
##########
@@ -114,13 +116,26 @@ case class EliminateRedundantTransitions(session:
SparkSession)
// source string/binary vectors always use 4-byte offsets while the
destination root is
// allocated with 8-byte offsets when this conf is on. The buffer counts
match but the
// offset width does not, so a direct memcpy would corrupt the offsets.
- case EligibleMapInBatch(info, columnarChild) =>
- CometMapInBatchExec(
- info.func,
- info.output,
- columnarChild,
- info.isBarrier,
- info.pythonEvalType)
+ //
+ // `EligibleMapInBatch` matches whenever the operator *would* run
natively if the feature
Review Comment:
I don't love how Claude enjoys putting emphasis like that in comments
(either ** or all caps). Let's remove that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
