XiangpengHao commented on code in PR #11884:
URL: https://github.com/apache/datafusion/pull/11884#discussion_r1709509871
##########
datafusion/functions/src/string/ascii.rs:
##########
@@ -87,12 +69,92 @@ impl ScalarUDFImpl for AsciiFunc {
}
fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
- match args[0].data_type() {
- DataType::Utf8 => make_scalar_function(ascii::<i32>, vec![])(args),
- DataType::LargeUtf8 => {
- return make_scalar_function(ascii::<i64>, vec![])(args);
- }
- _ => internal_err!("Unsupported data type"),
+ make_scalar_function(ascii, vec![])(args)
+ }
+}
+
+fn calculate_ascii<'a, I>(string_array: I) -> Result<ArrayRef>
+where
+ I: IntoIterator<Item = Option<&'a str>>,
+{
+ let result = string_array
+ .into_iter()
+ .map(|string| {
+ string.map(|s| {
+ let mut chars = s.chars();
+ chars.next().map_or(0, |v| v as i32)
+ })
+ })
+ .collect::<Int32Array>();
+
+ Ok(Arc::new(result) as ArrayRef)
+}
+
+/// Returns the numeric code of the first character of the argument.
+pub fn ascii(args: &[ArrayRef]) -> Result<ArrayRef> {
+ match args[0].data_type() {
+ DataType::Utf8 => {
+ let string_array = args[0].as_string::<i32>();
+ calculate_ascii(string_array.iter())
+ }
+ DataType::LargeUtf8 => {
+ let string_array = args[0].as_string::<i64>();
+ calculate_ascii(string_array.iter())
}
+ DataType::Utf8View => {
+ let string_array = args[0].as_string_view();
+ calculate_ascii(string_array.iter())
+ }
+ _ => unreachable!(),
Review Comment:
Should we return `internal_err!("Unsupported data type")` instead of panic
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
