hiSandog commented on issue #23086: URL: https://github.com/apache/datafusion/issues/23086#issuecomment-4942753192
The distinction between DataFusion's character-counting `length` and the byte-oriented ClickBench functions makes Q27/Q28 a semantic mismatch, not just a micro-optimization. Alongside timing comparisons, a small non-ASCII fixture could verify that `octet_length` preserves the intended benchmark result; ASCII-only data would not expose a future accidental switch back to character counting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
