fangchenli opened a new pull request, #1627:
URL: https://github.com/apache/datafusion-python/pull/1627
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #1626 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
`register_record_batches` read the schema via unchecked
`partitions.0[0][0]`, which panics when a partition contains no record batches
(e.g. the batches of an empty pyarrow table, whose `to_batches()` returns `[]`).
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Take the schema from the first available batch across all partitions and
return a clear error when there is none, mirroring the empty-table handling
added for `from_arrow_table` in #613. A non-empty later partition now also
works instead of panicking on an empty leading one.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
register_record_batches now raises a catchable Python Exception on empty
input instead of aborting with a Rust panic
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
