edmondop commented on code in PR #11753:
URL: https://github.com/apache/datafusion/pull/11753#discussion_r1709361036
##########
datafusion/functions/src/regex/regexplike.rs:
##########
@@ -75,13 +75,8 @@ impl ScalarUDFImpl for RegexpLikeFunc {
use DataType::*;
Ok(match &arg_types[0] {
- LargeUtf8 | Utf8 => Boolean,
Null => Null,
- other => {
- return plan_err!(
- "The regexp_like function can only accept strings. Got
{other}"
- );
- }
+ _ => Boolean,
Review Comment:
My bad I mixed up two things. In the thread about better error handling I
think we agreed to return a planning error in this scenario, and some form of
unreachable within the invoke function to signal that branch should never be
executed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
