andygrove opened a new pull request, #4890:
URL: https://github.com/apache/datafusion-comet/pull/4890
## Which issue does this PR close?
N/A. This is a test-only coverage improvement.
## Rationale for this change
The `unhex` SQL file tests did not exercise a couple of invalid-input cases.
`unhex` returns NULL when its argument contains non-hex characters or a null
character, and Comet should match Spark for these. Adding explicit cases guards
this behavior against regressions.
## What changes are included in this PR?
Adds coverage for `unhex('-123')` (contains a non-hex character) and
`unhex('\0')` (the null character) to
`spark/src/test/resources/sql-tests/expressions/string/unhex.sql`. The values
are added both to the column-path INSERT data and to a dedicated literal query
so both evaluation paths are checked.
## How are these changes tested?
`./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite unhex"
-Dtest=none` passes; Comet runs both new cases natively and matches Spark (both
return NULL).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
