Phoenix500526 commented on code in PR #23189: URL: https://github.com/apache/datafusion/pull/23189#discussion_r3548864174
########## datafusion/datasource/src/file_scan_config/mod.rs: ########## Review Comment: > Yes. We would have to take the column parttion values, sort them, and represent them as a range partitioning where each partition only contains the intended values. > > Example: > > ``` > partition 1: col = A > partition 2: col = Z > partition 3: col = M > ``` > > Represented like: > > ``` > Range Partitioning: > split points: [A, M, Z] > sort order: Asc > ``` > > Thus: > > ``` > partition 1: col <= A > parttion 2: A < col <= M > partition 3: M <= col (which contains Z) > ``` `RangePartitioning` needs to sort in order to derive the `split_points` while `ValuePartitioned` does not. Given that, would `ValuePartitioning` be a better choice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
