alamb commented on PR #23128:
URL: https://github.com/apache/datafusion/pull/23128#issuecomment-4903031891
Thanks for the ping -- I'll try to look at this some time, but I have a
bunch of other stuff to review first. Why is this feature important? Do we have
users grouping by FixedSizeList<primitive> ?
Specifically, I am worried that adding specialized code for all possible
types even when they aren't really used will lead to more code to maintain and
large binary sizes.
For example, this code
```rust
// `group_column_supported_type` already restricts the child to
// the primitive subset supported here. Any unsupported child
// type returned `false` upstream and was routed to the
// `GroupValuesRows` fallback, so the wildcard arm below is
// only reachable from the consistency-fuzz test.
macro_rules! instantiate_fsl {
($t:ty) => {{
let b =
fixed_size_list::FixedSizeListGroupValueBuilder::<$t>::new(
data_type,
);
v.push(Box::new(b) as _);
}};
}
match child_field.data_type() {
DataType::Int8 => instantiate_fsl!(Int8Type),
DataType::Int16 => instantiate_fsl!(Int16Type),
DataType::Int32 => instantiate_fsl!(Int32Type),
DataType::Int64 => instantiate_fsl!(Int64Type),
DataType::UInt8 => instantiate_fsl!(UInt8Type),
DataType::UInt16 => instantiate_fsl!(UInt16Type),
DataType::UInt32 => instantiate_fsl!(UInt32Type),
DataType::UInt64 => instantiate_fsl!(UInt64Type),
DataType::Float32 => instantiate_fsl!(Float32Type),
DataType::Float64 => instantiate_fsl!(Float64Type),
DataType::Date32 => instantiate_fsl!(Date32Type),
DataType::Date64 => instantiate_fsl!(Date64Type),
other => {
return not_impl_err!(
"FixedSizeList<{other}> not supported in
GroupValuesColumn"
);
}
}
```
Is likely going to create 12 copies of the new code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
