jayzhan211 commented on code in PR #11845: URL: https://github.com/apache/datafusion/pull/11845#discussion_r1706986908
########## datafusion/physical-expr-functions-aggregate/src/aggregate.rs: ########## @@ -61,11 +52,10 @@ pub mod utils; /// /// You can also create expression by [`AggregateExprBuilder`] #[allow(clippy::too_many_arguments)] +#[deprecated(since = "40.0.0", note = "Use `AggregateExprBuilder` instead")] pub fn create_aggregate_expr( Review Comment: Given we are changing APIs, do we still need to keep it deprecated or just remove it at all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
