jayzhan211 commented on code in PR #11845:
URL: https://github.com/apache/datafusion/pull/11845#discussion_r1706975742
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -395,6 +379,8 @@ impl BuiltInWindowFunctionExpr for WindowUDFExpr {
}
}
+// TODO: Find a way to make clippy happy
+#[allow(clippy::needless_borrow)]
Review Comment:
Interesting, actually it has no error. The error I got is from rust-analyzer.
`expected &Arc<dyn PhysicalExpr, Global>, found Arc<dyn PhysicalExpr,
Global>`
😕
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
