andygrove commented on code in PR #4744: URL: https://github.com/apache/datafusion-comet/pull/4744#discussion_r3529698841
########## spark/src/test/resources/sql-tests/expressions/array/array_filter.sql: ########## @@ -16,16 +16,22 @@ -- under the License. statement -CREATE TABLE test_array_filter(arr array<int>) USING parquet +CREATE TABLE test_array_filter(arr array<int>, threshold int) USING parquet statement -INSERT INTO test_array_filter VALUES (array(1, 2, 3, 4, 5)), (array(-1, 0, 1)), (array(10)), (NULL) +INSERT INTO test_array_filter VALUES (array(1, 2, 3, 4, 5), 10), (array(-1, 0, 1, NULL), 10), (array(NULL, NULL), 10), (array(10), 10), (NULL, 10), (array(), 10) query SELECT filter(arr, x -> x > 2) FROM test_array_filter query SELECT filter(arr, x -> x >= 0) FROM test_array_filter +query +SELECT filter(filter(arr, x -> x < threshold), y -> y > 0) FROM test_array_filter + +query +SELECT filter(filter(arr, x -> x < threshold), y -> y > 0) FROM test_array_filter Review Comment: These two tests seem identical? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
