freakyzoidberg opened a new pull request, #23335: URL: https://github.com/apache/datafusion/pull/23335
## Which issue does this PR close? Contributes to https://github.com/apache/datafusion/issues/23334 ## Rationale for this change In order to correctly characterize a performance improvement for array_has with column needle, needed more benchmark cover. ## What changes are included in this PR? Adds criterion benchmarks for `array_has` with an **array (column) needle** — the path through `array_has_dispatch_for_array` — with no functional change. Landed as its own PR against `main` so it can be run to capture the "before" baseline; the optimization is a separate PR (#1). Running `cargo bench --bench array_has` on `main` (this PR) and then on the optimization branch gives the before/after. Groups added in `datafusion/functions-nested/benches/array_has.rs`: - `array_has_array_i64` / `array_has_array_strings` — found / not-found over list sizes 10/100/500. - `array_has_array_null_patterns` — null patterns at list length 64: for i64, no nulls / 30% nulls found / 30% nulls not found / all null / null-fill collision; for Utf8, LargeUtf8, and Utf8View, no-nulls / 30% nulls at both short (inline, ≤ 12 byte) and long (> 12 byte, shared-prefix) element lengths, plus all-null. - `array_has_array_by_size` — i64, 30% element nulls, not found, list length 8..1024. - `array_has_array_by_rows` — i64, 8 elems/row, 30% nulls, not found, 10K / 100K / 1M rows. ## Are these changes tested? no functional change here ## Are there any user-facing changes? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
