buraksenn commented on PR #23323: URL: https://github.com/apache/datafusion/pull/23323#issuecomment-4885931975
> How about using ` cfg!(debug_assertions)` which adds an explicit `assert!(result.is_ok())` for release mode and removes the need to gate `InvariantFailsExtensionNode`, giving strictly better coverage with less #[cfg] surface. Thanks, I did not think of this. I've applied it just now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
