xudong963 commented on code in PR #23319:
URL: https://github.com/apache/datafusion/pull/23319#discussion_r3524356965
##########
datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs:
##########
@@ -754,6 +867,90 @@ mod tests {
(partitions.clone(), *completed_partitions)
}
+ #[test]
+ fn collect_left_updates_with_membership_only() {
+ let acc = make_collect_left_accumulator_for_test();
+
+ acc.build_filter(FinalizeInput::CollectLeft(reported(
+ in_list(&[1, 2, 3]),
+ no_bounds(),
+ )))
+ .unwrap();
+
+ let expr = current_expr(&acc);
+ in_list_expr(&expr);
Review Comment:
after `in_list_expr(&expr)`, also asserting the child column and the in-list
values are `[1,2,3]` would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
