paleolimbot commented on code in PR #23169:
URL: https://github.com/apache/datafusion/pull/23169#discussion_r3507419103


##########
datafusion/physical-expr/Cargo.toml:
##########
@@ -51,6 +51,7 @@ proto = [
 
 [dependencies]
 arrow = { workspace = true }
+arrow-schema = { workspace = true }

Review Comment:
   I couldn't figure out how to get `arrow_schema::extension::<constants>` to 
show up (I don't think `schema` is pub exported from `arrow`). I can also 
inline the constants for metadata key/value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to