schenksj commented on PR #4532: URL: https://github.com/apache/datafusion-comet/pull/4532#issuecomment-4827360772
Thanks @mbutrovich, @andygrove — all review feedback is addressed in 18c147f19: - @andygrove's Preflight failure: registered `org.apache.comet.vector.NativeUtilSuite` in both `pr_build_linux.yml` and `pr_build_macos.yml` (next to `UtilsSuite`). - @mbutrovich's three nits (replied inline): dropped the `Utils.materializeConstantColumnVector` forwarder so both callers hit `ConstantColumnVectors.materialize` directly with the UTC rationale living once on that method; switched `NativeUtil` to the imported short names; and made the export arm read `numRows += materialised.getValueCount`, symmetric with the `CometVector` arm. Verified locally: `NativeUtilSuite` + `UtilsSuite` pass (6/6) on Spark 4.1/2.13, and the spark module also compiles clean under Scala 2.12 (Spark 3.4). (Disclosure: these changes and this response were written with help from AI — Claude Code.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
