viirya commented on code in PR #784:
URL: https://github.com/apache/datafusion-comet/pull/784#discussion_r1704951869
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -1234,24 +1233,51 @@ impl PhysicalPlanner {
) -> Result<Arc<dyn AggregateExpr>, ExecutionError> {
match spark_expr.expr_struct.as_ref().unwrap() {
AggExprStruct::Count(expr) => {
- let children = expr
- .children
- .iter()
- .map(|child| self.create_expr(child, schema.clone()))
- .collect::<Result<Vec<_>, _>>()?;
+ if expr.children.iter().len() == 1 {
Review Comment:
Hmm, I think we can also do this for multiple child expressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
