Jefffrey commented on code in PR #22921: URL: https://github.com/apache/datafusion/pull/22921#discussion_r3424891073
########## datafusion/functions-aggregate/src/approx_distinct.rs: ########## Review Comment: does this mean in a followup PR we can add support for the other types, now that its generic over the hashing code from `hash_utils`? (also I noticed we were missing binaryview already) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
