0lai0 commented on PR #4653:
URL:
https://github.com/apache/datafusion-comet/pull/4653#issuecomment-4720406941
I've reverted the #4514 diff changes. After the revert,
`udf/postgreSQL/udf-select_having.sql` is now failing:
`SELECT 1 AS one FROM test_having WHERE 1/udf(a) = 1 HAVING 1 < 2`
`External: Compute error: Error evaluating filter predicate:
External(SparkErrorWithContext { error: DivideByZero, ... })
`
This PR fixes the error type for the project/aggregate path (e.g. `SELECT
1/udf(a) FROM t`), but this query goes through filter predicate evaluation
instead. The typed `SparkErrorWithContext` appears to get stringified before it
can be unwrapped by the JNI bridge, so it still surfaces as
`CometNativeException` rather than `SparkArithmeticException`.
Should I extend this PR to cover the filter path too, or file a separate
issue and keep this test excluded for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
