lyne7-sc commented on code in PR #22905:
URL: https://github.com/apache/datafusion/pull/22905#discussion_r3414173009
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -1062,12 +1064,37 @@ pub enum Coercion {
desired_type: TypeSignatureClass,
/// Rules for implicit coercion from other types
implicit_coercion: ImplicitCoercion,
+ /// Physical encoding preservation requested by the function.
+ encoding_preservation: EncodingPreservation,
},
}
+/// Controls whether a [`Coercion`] preserves an argument's physical encoding
+/// (e.g. dictionary) instead of materializing it to the coerced value type.
+#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Hash)]
+pub enum EncodingPreservation {
+ /// Do not request preservation of a physical encoding.
+ None,
+ /// Preserve dictionary encoding and coerce only the dictionary values.
+ Dictionary,
+}
Review Comment:
Considering RunEndEncoded and other potential encoding types, I agree that
using a struct with boolean flags is a better approach. It keeps the complexity
low while making it easier to add future preservation options without
introducing enum variants for every possible combination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
