asolimando commented on PR #21815: URL: https://github.com/apache/datafusion/pull/21815#issuecomment-4706788721
> Thank you @asolimando and @xudong963 -- I just went over this PR again and I think it looks like a nice step forward. > > I have two small suggestions: > > * [asolimando#1](https://github.com/asolimando/datafusion/pull/1) > * [asolimando#2](https://github.com/asolimando/datafusion/pull/2) > > However, I am also happy to implement them as their own follow on PRs Thank you @alamb for the approval and for preparing the two PRs, I have cherry-picked both and just added a small follow-up commit to adapt the FFI call sites to the new builder-style API. Apologies for the late reply but I was off last week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
