kosiew commented on code in PR #22892:
URL: https://github.com/apache/datafusion/pull/22892#discussion_r3412212661
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -2585,63 +2586,108 @@ impl ScalarValue {
/// distance is greater than [`usize::MAX`]. If the type is a float, then
the distance will be
/// rounded to the nearest integer.
///
- ///
/// Note: the datatype itself must support subtraction.
+ #[deprecated(since = "54.0.0", note = "Use distance_u64 instead")]
Review Comment:
Thanks for the updates here. One remaining concern: `ScalarValue::distance`
is a public method and it is now marked as `#[deprecated]`, while the workspace
version is still `54.0.0`.
The semver bot is reporting this as a minor-version API change, so could we
either remove or defer the deprecation in this PR, or make sure the semver and
versioning policy is explicitly satisfied before merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
