huan233usc commented on code in PR #22839:
URL: https://github.com/apache/datafusion/pull/22839#discussion_r3410664111
##########
datafusion-cli/src/main.rs:
##########
@@ -330,8 +340,16 @@ fn get_session_config(args: &Args) ->
Result<SessionConfig> {
config_options.format.null = String::from("NULL");
}
- let session_config =
+ let mut session_config =
SessionConfig::from(config_options).with_information_schema(true);
+
+ if args.repl_mode() {
Review Comment:
Thanks @kosiew, fixed. The guard no longer keys on `repl_mode()` —
`StdinCarriesCommands` is now installed whenever stdin carries the SQL, i.e.
the REPL **or** a `-f` arg resolving to a stdin pseudo-path (`/dev/stdin`,
`/dev/fd/0`, `/proc/self/fd/0`), so `-f /dev/stdin` hits the same clear error.
Added `test_cli_dash_f_stdin_location_rejected` to cover it. PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
