getChan opened a new pull request, #4647:
URL: https://github.com/apache/datafusion-comet/pull/4647
## Which issue does this PR close?
Closes #4631.
## Rationale for this change
Comet should render Spark map-to-string casts natively for non-empty maps,
matching Spark's `{k -> v, ...}` formatting. Empty `map()` still falls back
because Catalyst types it as `Map<NullType, NullType>`; no special-case
handling is added here, so once null casting is supported this path should work
naturally.
## What changes are included in this PR?
- Add native map-to-string rendering in `native/spark-expr`.
- Update `CometCast` support checks so non-empty maps can execute natively.
- Replace fallback expectations with result assertions for map string cases
in `cast_complex_types_to_string.sql`, while keeping empty map fallback.
- Add Scala regression coverage for the support check.
- Used the `implement-comet-expression` workflow to scaffold the
implementation.
## How are these changes tested?
- `PROFILES='-Pspark-4.0' make format`
- `./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite
cast_complex_types_to_string" -Dtest=none`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
