pchintar commented on PR #22697: URL: https://github.com/apache/datafusion/pull/22697#issuecomment-4657077318
Hi @Jefffrey I replaced the custom integer-type helper with `DataType::is_integer()` and restored the original `UInt64` handling in the Spark implementation, since Spark doesn't expose a `UInt64` type. I also reran the existing tests and manually verified the `Int64`/`UInt64` rounding cases to make sure the behavior is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
