coderfender commented on code in PR #4429:
URL: https://github.com/apache/datafusion-comet/pull/4429#discussion_r3374621045
##########
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##########
@@ -702,4 +705,102 @@ class CometJoinSuite extends CometTestBase {
}
}
}
+
+ test("BroadcastNestedLoopJoin with unequal filter") {
Review Comment:
Thank you.
1. Added LeftOuter + BuildLeft, FullOuter tests which should fall back to
spark.
2. Also added nulls to input data for all the test cases to verify null
join key condition as well
3. Broadcast reuse was a great idea ! I added a test to verify that as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
