github-actions[bot] commented on PR #22816: URL: https://github.com/apache/datafusion/pull/22816#issuecomment-4645884118
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) error: running cargo-doc on crate 'datafusion' failed with output: ----- Compiling proc-macro2 v1.0.106 Compiling unicode-ident v1.0.24 Compiling quote v1.0.45 Compiling libc v0.2.186 Checking cfg-if v1.0.4 Compiling shlex v2.0.1 Compiling autocfg v1.5.1 Compiling find-msvc-tools v0.1.9 Compiling libm v0.2.16 Compiling num-traits v0.2.19 Checking memchr v2.8.1 Compiling syn v2.0.117 Compiling version_check v0.9.5 Compiling jobserver v0.1.34 Checking bytes v1.11.1 Compiling cc v1.2.63 Compiling zerocopy v0.8.50 Compiling serde_core v1.0.228 Checking equivalent v1.0.2 Checking foldhash v0.2.0 Checking itoa v1.0.18 Checking once_cell v1.21.4 Compiling getrandom v0.3.4 Checking allocator-api2 v0.2.21 Checking hashbrown v0.17.1 Compiling zmij v1.0.21 Checking indexmap v2.14.0 Checking num-integer v0.1.46 Compiling serde_json v1.0.150 Compiling serde v1.0.228 Checking num-bigint v0.4.6 Checking siphasher v1.0.3 Compiling pkg-config v0.3.33 Compiling synstructure v0.13.2 Checking iana-time-zone v0.1.65 Checking chrono v0.4.45 Checking phf_shared v0.12.1 Compiling ahash v0.8.12 Checking stable_deref_trait v1.2.1 Compiling chrono-tz v0.10.4 Checking phf v0.12.1 Checking num-complex v0.4.6 Compiling zstd-sys v2.0.16+zstd.1.5.7 Checking pin-project-lite v0.2.17 Compiling object v0.37.3 Checking litemap v0.8.2 Checking writeable v0.6.3 Checking futures-sink v0.3.32 Checking futures-core v0.3.32 Checking smallvec v1.15.1 Compiling zerocopy-derive v0.8.50 Compiling serde_derive v1.0.228 Compiling zerofrom-derive v0.1.7 Checking half v2.7.1 Compiling yoke-derive v0.8.2 Checking zerofrom v0.1.8 Checking arrow-buffer v58.3.0 Checking arrow-schema v58.3.0 Compiling zerovec-derive v0.11.3 Checking arrow-data v58.3.0 Checking yoke v0.8.3 Compiling displaydoc v0.2.6 Checking arrow-array v58.3.0 Compiling zstd-safe v7.2.4 Checking lexical-util v1.0.7 Checking zerovec v0.11.6 Checking zerotrie v0.2.4 Compiling icu_properties_data v2.2.0 Checking tinystr v0.8.3 Checking icu_locale_core v2.2.0 Checking potential_utf v0.1.5 Checking utf8_iter v1.0.4 Compiling icu_normalizer_data v2.2.0 Checking icu_collections v2.2.0 Checking icu_provider v2.2.0 Checking arrow-select v58.3.0 Compiling tokio-macros v2.7.0 Compiling crc32fast v1.5.0 Compiling semver v1.0.28 Checking tokio v1.52.3 Compiling rustc_version v0.4.1 Checking lexical-parse-integer v1.0.6 Checking lexical-write-integer v1.0.6 Compiling futures-macro v0.3.32 Checking futures-channel v0.3.32 Checking futures-io v0.3.32 Checking bitflags v2.13.0 Checking slab v0.4.12 Checking simd-adler32 v0.3.9 Checking futures-task v0.3.32 Checking adler2 v2.0.1 Compiling parking_lot_core v0.9.12 Checking miniz_oxide v0.8.9 Checking futures-util v0.3.32 Compiling ar_archive_writer v0.5.1 Checking lexical-write-float v1.0.6 Checking lexical-parse-float v1.0.6 Checking icu_normalizer v2.2.0 Compiling psm v0.1.31 Checking icu_properties v2.2.0 Compiling flatbuffers v25.12.19 Checking aho-corasick v1.1.4 Checking scopeguard v1.2.0 Checking regex-syntax v0.8.10 Checking unicode-segmentation v1.13.3 Compiling getrandom v0.4.2 Checking zlib-rs v0.6.3 Checking base64 v0.22.1 Checking unicode-width v0.2.2 Checking ryu v1.0.23 Checking comfy-table v7.2.2 Checking lock_api v0.4.14 Checking regex-automata v0.4.14 Checking idna_adapter v1.2.2 Checking flate2 v1.1.9 Checking lexical-core v1.0.6 Checking arrow-ord v58.3.0 Compiling stacker v0.1.24 Checking atoi v2.0.0 Checking percent-encoding v2.3.2 Compiling snap v1.1.1 Checking twox-hash v2.1.2 Checking alloc-no-stdlib v2.0.4 Compiling thiserror v2.0.18 Checking alloc-stdlib v0.2.2 Checking lz4_flex v0.13.1 Checking regex v1.12.3 Checking form_urlencoded v1.2.2 Checking arrow-cast v58.3.0 Checking idna v1.1.0 Checking futures-executor v0.3.32 Compiling thiserror-impl v2.0.18 Compiling tracing-attributes v0.1.31 Compiling ring v0.17.14 Checking tracing-core v0.1.36 Checking csv-core v0.1.13 Checking same-file v1.0.6 Compiling paste v1.0.15 Checking simdutf8 v0.1.5 Checking either v1.16.0 Checking tracing v0.1.44 Checking itertools v0.14.0 Checking walkdir v2.5.0 Checking csv v1.4.0 Checking futures v0.3.32 Checking url v2.5.8 Checking brotli-decompressor v5.0.1 Checking parking_lot v0.12.5 Compiling async-trait v0.1.89 Compiling recursive-proc-macro-impl v0.1.1 Checking http v1.4.1 Checking ordered-float v2.10.1 Checking getrandom v0.2.17 Checking byteorder v1.5.0 Checking log v0.4.32 Checking untrusted v0.9.0 Checking humantime v2.3.0 Checking integer-encoding v3.0.4 Checking thrift v0.17.0 Checking object_store v0.13.2 Checking brotli v8.0.3 Checking recursive v0.1.1 Checking arrow-csv v58.3.0 Checking zstd v0.13.3 Checking arrow-json v58.3.0 Checking arrow-ipc v58.3.0 Checking uuid v1.23.2 Checking arrow-string v58.3.0 Checking arrow-row v58.3.0 Checking arrow-arith v58.3.0 Compiling sqlparser_derive v0.5.0 Compiling seq-macro v0.3.6 Checking hex v0.4.3 Checking typenum v1.20.1 Checking parquet v58.3.0 Checking arrow v58.3.0 Compiling pin-project-internal v1.1.13 Checking sqlparser v0.62.0 Compiling generic-array v0.14.7 Checking datafusion-doc v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/doc) Checking hybrid-array v0.4.12 Checking pin-project v1.1.13 Checking ppv-lite86 v0.2.21 Checking rand_core v0.9.5 Compiling rustix v1.1.4 Compiling crossbeam-utils v0.8.21 Checking foldhash v0.1.5 Checking hashbrown v0.15.5 Checking rand_chacha v0.9.0 Checking linux-raw-sys v0.12.1 Checking fixedbitset v0.5.7 Checking petgraph v0.8.3 Checking rand v0.9.4 Checking block-buffer v0.12.0 Checking crypto-common v0.2.2 Checking const-oid v0.10.2 Checking hashbrown v0.14.5 Checking fastrand v2.4.1 Checking tempfile v3.27.0 Checking dashmap v6.2.1 Compiling datafusion-macros v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/macros) Checking digest v0.11.3 Checking crypto-common v0.1.7 Checking block-buffer v0.10.4 Compiling blake3 v1.8.5 Checking cpufeatures v0.3.0 Checking subtle v2.6.1 Checking arrayref v0.3.9 Checking digest v0.10.7 Checking arrayvec v0.7.6 Checking constant_time_eq v0.4.2 Checking blake2 v0.10.6 Checking sha2 v0.11.0 Checking md-5 v0.11.0 Compiling liblzma-sys v0.4.6 Checking libbz2-rs-sys v0.2.5 Checking datafusion-common-runtime v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/common-runtime) Checking compression-core v0.4.32 Checking tokio-util v0.7.18 Checking bzip2 v0.6.1 Checking glob v0.3.3 Compiling bigdecimal v0.4.10 Checking crc-catalog v2.5.0 Compiling heck v0.5.0 Checking crc v3.4.0 Compiling strum_macros v0.28.0 Checking tokio-stream v0.1.18 Checking liblzma v0.4.6 Checking compression-codecs v0.4.38 Checking arrow-avro v58.3.0 Checking async-compression v0.4.42 Checking datafusion-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/common) Checking datafusion-expr-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/expr-common) Checking datafusion-physical-expr-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-common) Checking datafusion-functions-window-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window-common) Checking datafusion-functions-aggregate-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common) Checking datafusion-expr v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/expr) Checking datafusion-physical-expr v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr) Checking datafusion-execution v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/execution) Checking datafusion-functions v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions) Checking datafusion-functions-aggregate v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate) Checking datafusion-optimizer v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/optimizer) Checking datafusion-functions-window v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window) error[E0050]: method `merge_batch` has 5 parameters but the declaration in trait `datafusion_expr::GroupsAccumulator::merge_batch` has 4 --> /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate/src/approx_distinct.rs:684:9 | 684 | / &mut self, 685 | | values: &[ArrayRef], 686 | | group_indices: &[usize], ... | 689 | | total_num_groups: usize, | |_______________________________^ expected 4 parameters, found 5 | = note: `merge_batch` from trait: `fn(&mut Self, &[Arc<(dyn arrow::array::Array + 'static)>], &[usize], usize) -> Result<(), DataFusionError>` help: remove the extra parameter to match the trait | 688 - opt_filter: Option<&BooleanArray>, 689 - total_num_groups: usize, 688 + opt_filter: Option<&BooleanArray>, | Checking datafusion-physical-plan v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-plan) Checking datafusion-physical-expr-adapter v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-adapter) For more information about this error, try `rustc --explain E0050`. error: could not compile `datafusion-functions-aggregate` (lib) due to 1 previous error warning: build failed, waiting for other jobs to finish... error[E0061]: this method takes 3 arguments but 4 arguments were supplied --> /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/hash_table.rs:206:26 | 206 | self.accumulator.merge_batch( | ^^^^^^^^^^^ ... 209 | None, | ---- unexpected argument #3 of type `Option<_>` | note: method defined here --> /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/groups_accumulator.rs:190:8 | 190 | fn merge_batch( | ^^^^^^^^^^^ help: remove the extra argument | 208 - group_indices, 209 - None, 208 + group_indices, | For more information about this error, try `rustc --explain E0061`. error: could not compile `datafusion-physical-plan` (lib) due to 1 previous error ----- error: failed to build rustdoc for crate datafusion v53.1.0 note: this is usually due to a compilation error in the crate, and is unlikely to be a bug in cargo-semver-checks note: the following command can be used to reproduce the error: cargo new --lib example && cd example && echo '[workspace]' >> Cargo.toml && cargo add --path /home/runner/work/datafusion/datafusion/datafusion/core --features array_expressions,avro,backtrace,bzip2,compression,crypto_expressions,datafusion-datasource-avro,datafusion-datasource-parquet,datafusion-functions-nested,datafusion-sql,datetime_expressions,default,encoding_expressions,extended_tests,flate2,force_hash_collisions,liblzma,math_expressions,nested_expressions,parquet,parquet_encryption,recursive_protection,regex_expressions,serde,sql,sqlparser,string_expressions,unicode_expressions,zstd && cargo check && cargo doc Building datafusion-expr-common v53.1.0 (current) Built [ 18.204s] (current) Parsing datafusion-expr-common v53.1.0 (current) Parsed [ 0.018s] (current) Building datafusion-expr-common v53.1.0 (baseline) Built [ 18.753s] (baseline) Parsing datafusion-expr-common v53.1.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-expr-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.209s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_parameter_count_changed.ron Failed in: GroupsAccumulator::merge_batch now takes 3 instead of 4 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/groups_accumulator.rs:190 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 37.910s] datafusion-expr-common Building datafusion-ffi v53.1.0 (current) error: running cargo-doc on crate 'datafusion-ffi' failed with output: ----- Compiling proc-macro2 v1.0.106 Compiling quote v1.0.45 Compiling unicode-ident v1.0.24 Compiling libc v0.2.186 Checking cfg-if v1.0.4 Compiling autocfg v1.5.1 Compiling libm v0.2.16 Checking memchr v2.8.1 Compiling num-traits v0.2.19 Compiling syn v2.0.117 Compiling zerocopy v0.8.50 Checking bytes v1.11.1 Checking once_cell v1.21.4 Compiling getrandom v0.3.4 Checking equivalent v1.0.2 Checking allocator-api2 v0.2.21 Compiling serde_core v1.0.228 Checking foldhash v0.2.0 Checking itoa v1.0.18 Checking hashbrown v0.17.1 Checking bitflags v2.13.0 Compiling zmij v1.0.21 Compiling serde_json v1.0.150 Checking indexmap v2.14.0 Checking num-integer v0.1.46 Checking iana-time-zone v0.1.65 Checking stable_deref_trait v1.2.1 Compiling version_check v0.9.5 Checking siphasher v1.0.3 Compiling ahash v0.8.12 Checking phf_shared v0.12.1 Checking chrono v0.4.45 Checking num-bigint v0.4.6 Compiling chrono-tz v0.10.4 Checking phf v0.12.1 Checking num-complex v0.4.6 Compiling synstructure v0.13.2 Checking arrow-schema v58.3.0 Compiling semver v1.0.28 Compiling rustc_version v0.4.1 Compiling jobserver v0.1.34 Compiling find-msvc-tools v0.1.9 Checking pin-project-lite v0.2.17 Compiling shlex v2.0.1 Checking litemap v0.8.2 Compiling cc v1.2.63 Checking futures-core v0.3.32 Checking futures-sink v0.3.32 Compiling pkg-config v0.3.33 Compiling zerocopy-derive v0.8.50 Compiling zerofrom-derive v0.1.7 Compiling yoke-derive v0.8.2 Checking zerofrom v0.1.8 Compiling zerovec-derive v0.11.3 Checking yoke v0.8.3 Compiling displaydoc v0.2.6 Checking zerovec v0.11.6 Checking writeable v0.6.3 Checking lexical-util v1.0.7 Checking tinystr v0.8.3 Checking smallvec v1.15.1 Checking icu_locale_core v2.2.0 Checking potential_utf v0.1.5 Checking zerotrie v0.2.4 Compiling zstd-sys v2.0.16+zstd.1.5.7 Checking utf8_iter v1.0.4 Compiling icu_normalizer_data v2.2.0 Compiling icu_properties_data v2.2.0 Checking icu_collections v2.2.0 Checking icu_provider v2.2.0 Checking lexical-write-integer v1.0.6 Checking lexical-parse-integer v1.0.6 Compiling futures-macro v0.3.32 Compiling tokio-macros v2.7.0 Checking futures-channel v0.3.32 Compiling parking_lot_core v0.9.12 Checking slab v0.4.12 Checking futures-io v0.3.32 Compiling zstd-safe v7.2.4 Checking futures-task v0.3.32 Checking tokio v1.52.3 Checking futures-util v0.3.32 Checking half v2.7.1 Checking arrow-buffer v58.3.0 Checking arrow-data v58.3.0 Checking arrow-array v58.3.0 Checking lexical-write-float v1.0.6 Checking lexical-parse-float v1.0.6 Checking icu_properties v2.2.0 Checking icu_normalizer v2.2.0 Compiling flatbuffers v25.12.19 Checking aho-corasick v1.1.4 Checking ryu v1.0.23 Checking unicode-segmentation v1.13.3 Checking arrow-select v58.3.0 Checking regex-syntax v0.8.10 Checking base64 v0.22.1 Checking scopeguard v1.2.0 Checking unicode-width v0.2.2 Checking comfy-table v7.2.2 Checking lock_api v0.4.14 Checking idna_adapter v1.2.2 Checking lexical-core v1.0.6 Checking arrow-ord v58.3.0 Checking atoi v2.0.0 Compiling thiserror v2.0.18 Compiling getrandom v0.4.2 Checking alloc-no-stdlib v2.0.4 Checking twox-hash v2.1.2 Checking percent-encoding v2.3.2 Checking lz4_flex v0.13.1 Checking form_urlencoded v1.2.2 Checking regex-automata v0.4.14 Checking alloc-stdlib v0.2.2 Checking arrow-cast v58.3.0 Checking idna v1.1.0 Checking futures-executor v0.3.32 Compiling tracing-attributes v0.1.31 Compiling thiserror-impl v2.0.18 Checking regex v1.12.3 Checking tracing-core v0.1.36 Checking csv-core v0.1.13 Checking either v1.16.0 Compiling snap v1.1.1 Compiling paste v1.0.15 Checking simdutf8 v0.1.5 Checking same-file v1.0.6 Checking walkdir v2.5.0 Checking itertools v0.14.0 Checking tracing v0.1.44 Checking csv v1.4.0 Checking futures v0.3.32 Checking url v2.5.8 Checking brotli-decompressor v5.0.1 Checking parking_lot v0.12.5 Compiling async-trait v0.1.89 Checking http v1.4.1 Checking ordered-float v2.10.1 Compiling anyhow v1.0.102 Checking integer-encoding v3.0.4 Checking humantime v2.3.0 Checking byteorder v1.5.0 Checking zlib-rs v0.6.3 Checking object_store v0.13.2 Checking thrift v0.17.0 Checking brotli v8.0.3 Checking flate2 v1.1.9 Checking arrow-csv v58.3.0 Checking arrow-json v58.3.0 Checking arrow-string v58.3.0 Checking arrow-arith v58.3.0 Checking arrow-row v58.3.0 Checking zstd v0.13.3 Checking arrow-ipc v58.3.0 Compiling seq-macro v0.3.6 Checking log v0.4.32 Checking uuid v1.23.2 Compiling pin-project-internal v1.1.13 Compiling rustix v1.1.4 Compiling crossbeam-utils v0.8.21 Checking datafusion-doc v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/doc) Checking parquet v58.3.0 Checking arrow v58.3.0 Checking ppv-lite86 v0.2.21 Checking rand_core v0.9.5 Checking pin-project v1.1.13 Compiling prost-derive v0.14.4 Checking linux-raw-sys v0.12.1 Checking foldhash v0.1.5 Checking hashbrown v0.15.5 Checking rand_chacha v0.9.0 Checking fastrand v2.4.1 Checking hashbrown v0.14.5 Checking prost v0.14.4 Checking fixedbitset v0.5.7 Checking tempfile v3.27.0 Checking petgraph v0.8.3 Checking dashmap v6.2.1 Compiling datafusion-macros v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/macros) Checking rand v0.9.4 Checking hex v0.4.3 Checking datafusion-common-runtime v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/common-runtime) Checking glob v0.3.3 Compiling getrandom v0.2.17 Compiling winnow v1.0.3 Compiling toml_parser v1.1.2+spec-1.1.0 Compiling rand_core v0.6.4 Compiling syn v1.0.109 Compiling toml_datetime v1.1.1+spec-1.1.0 Checking datafusion-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/common) Compiling rustversion v1.0.22 Compiling toml_edit v0.25.12+spec-1.1.0 Compiling stabby-macros v72.1.2 Compiling proc-macro-crate v3.5.0 Checking tokio-util v0.7.18 Compiling stabby-abi v72.1.2 Checking tokio-stream v0.1.18 Compiling rand_chacha v0.3.1 Compiling rand v0.8.6 Checking sha2-const-stable v0.1.0 Compiling stabby v72.1.2 Checking libloading v0.9.0 Checking async-ffi v0.5.0 Checking datafusion-proto-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/proto-common) Checking datafusion-expr-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/expr-common) Checking datafusion-proto-models v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/proto-models) Checking datafusion-physical-expr-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-common) Checking datafusion-functions-aggregate-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common) Checking datafusion-functions-window-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window-common) Checking datafusion-expr v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/expr) Checking datafusion-execution v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/execution) Checking datafusion-physical-expr v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr) Checking datafusion-functions v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions) Checking datafusion-functions-window v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window) Checking datafusion-functions-aggregate v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate) error[E0050]: method `merge_batch` has 5 parameters but the declaration in trait `datafusion_expr::GroupsAccumulator::merge_batch` has 4 --> /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate/src/approx_distinct.rs:684:9 | 684 | / &mut self, 685 | | values: &[ArrayRef], 686 | | group_indices: &[usize], ... | 689 | | total_num_groups: usize, | |_______________________________^ expected 4 parameters, found 5 | = note: `merge_batch` from trait: `fn(&mut Self, &[Arc<(dyn arrow::array::Array + 'static)>], &[usize], usize) -> Result<(), DataFusionError>` help: remove the extra parameter to match the trait | 688 - opt_filter: Option<&BooleanArray>, 689 - total_num_groups: usize, 688 + opt_filter: Option<&BooleanArray>, | For more information about this error, try `rustc --explain E0050`. error: could not compile `datafusion-functions-aggregate` (lib) due to 1 previous error warning: build failed, waiting for other jobs to finish... ----- error: failed to build rustdoc for crate datafusion-ffi v53.1.0 note: this is usually due to a compilation error in the crate, and is unlikely to be a bug in cargo-semver-checks note: the following command can be used to reproduce the error: cargo new --lib example && cd example && echo '[workspace]' >> Cargo.toml && cargo add --path /home/runner/work/datafusion/datafusion/datafusion/ffi --features datafusion-functions,datafusion-functions-aggregate,datafusion-functions-table,datafusion-functions-window,integration-tests,tarpaulin_include && cargo check && cargo doc Building datafusion-functions-aggregate v53.1.0 (current) error: running cargo-doc on crate 'datafusion-functions-aggregate' failed with output: ----- Compiling proc-macro2 v1.0.106 Compiling quote v1.0.45 Compiling unicode-ident v1.0.24 Compiling libc v0.2.186 Checking cfg-if v1.0.4 Compiling autocfg v1.5.1 Compiling libm v0.2.16 Checking memchr v2.8.1 Compiling num-traits v0.2.19 Compiling zerocopy v0.8.50 Compiling syn v2.0.117 Checking itoa v1.0.18 Compiling serde_core v1.0.228 Compiling getrandom v0.3.4 Checking once_cell v1.21.4 Compiling zmij v1.0.21 Checking bytes v1.11.1 Compiling serde_json v1.0.150 Checking num-integer v0.1.46 Compiling version_check v0.9.5 Checking foldhash v0.2.0 Checking iana-time-zone v0.1.65 Checking allocator-api2 v0.2.21 Checking siphasher v1.0.3 Checking equivalent v1.0.2 Checking phf_shared v0.12.1 Checking chrono v0.4.45 Checking hashbrown v0.17.1 Compiling ahash v0.8.12 Checking num-bigint v0.4.6 Compiling chrono-tz v0.10.4 Checking phf v0.12.1 Checking num-complex v0.4.6 Checking arrow-schema v58.3.0 Compiling synstructure v0.13.2 Compiling find-msvc-tools v0.1.9 Compiling shlex v2.0.1 Checking lexical-util v1.0.7 Compiling pkg-config v0.3.33 Compiling jobserver v0.1.34 Compiling cc v1.2.63 Checking stable_deref_trait v1.2.1 Checking lexical-write-integer v1.0.6 Compiling zerocopy-derive v0.8.50 Compiling zerofrom-derive v0.1.7 Checking zerofrom v0.1.8 Compiling yoke-derive v0.8.2 Compiling zstd-sys v2.0.16+zstd.1.5.7 Checking yoke v0.8.3 Checking lexical-parse-integer v1.0.6 Compiling semver v1.0.28 Checking smallvec v1.15.1 Checking pin-project-lite v0.2.17 Compiling rustc_version v0.4.1 Checking lexical-parse-float v1.0.6 Checking lexical-write-float v1.0.6 Compiling zerovec-derive v0.11.3 Checking aho-corasick v1.1.4 Checking unicode-segmentation v1.13.3 Checking ryu v1.0.23 Checking regex-syntax v0.8.10 Compiling zstd-safe v7.2.4 Checking bitflags v2.13.0 Checking unicode-width v0.2.2 Checking comfy-table v7.2.2 Checking zerovec v0.11.6 Checking lexical-core v1.0.6 Checking half v2.7.1 Compiling flatbuffers v25.12.19 Compiling displaydoc v0.2.6 Checking arrow-buffer v58.3.0 Checking regex-automata v0.4.14 Checking atoi v2.0.0 Checking arrow-data v58.3.0 Checking base64 v0.22.1 Compiling getrandom v0.4.2 Checking indexmap v2.14.0 Checking arrow-array v58.3.0 Checking csv-core v0.1.13 Compiling parking_lot_core v0.9.12 Checking twox-hash v2.1.2 Checking lz4_flex v0.13.1 Checking regex v1.12.3 Checking csv v1.4.0 Compiling tokio-macros v2.7.0 Checking simdutf8 v0.1.5 Checking either v1.16.0 Checking arrow-select v58.3.0 Checking scopeguard v1.2.0 Checking lock_api v0.4.14 Checking itertools v0.14.0 Checking tokio v1.52.3 Checking arrow-ord v58.3.0 Checking arrow-cast v58.3.0 Checking arrow-string v58.3.0 Checking arrow-arith v58.3.0 Checking arrow-json v58.3.0 Checking arrow-csv v58.3.0 Checking arrow-row v58.3.0 Checking tinystr v0.8.3 Checking litemap v0.8.2 Checking writeable v0.6.3 Checking uuid v1.23.2 Checking icu_locale_core v2.2.0 Checking zerotrie v0.2.4 Checking potential_utf v0.1.5 Compiling icu_normalizer_data v2.2.0 Checking log v0.4.32 Checking utf8_iter v1.0.4 Compiling icu_properties_data v2.2.0 Checking icu_collections v2.2.0 Checking parking_lot v0.12.5 Compiling pin-project-internal v1.1.13 Checking icu_provider v2.2.0 Checking futures-sink v0.3.32 Checking futures-core v0.3.32 Checking icu_normalizer v2.2.0 Checking futures-channel v0.3.32 Checking icu_properties v2.2.0 Compiling futures-macro v0.3.32 Checking pin-project v1.1.13 Checking futures-task v0.3.32 Checking futures-io v0.3.32 Checking slab v0.4.12 Compiling async-trait v0.1.89 Checking futures-util v0.3.32 Checking idna_adapter v1.2.2 Checking percent-encoding v2.3.2 Compiling rustix v1.1.4 Compiling crossbeam-utils v0.8.21 Compiling thiserror v2.0.18 Checking form_urlencoded v1.2.2 Checking idna v1.1.0 Checking ppv-lite86 v0.2.21 Checking zstd v0.13.3 Checking arrow-ipc v58.3.0 Compiling thiserror-impl v2.0.18 Compiling tracing-attributes v0.1.31 Checking arrow v58.3.0 Checking datafusion-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/common) Checking rand_core v0.9.5 Checking tracing-core v0.1.36 Checking same-file v1.0.6 Checking linux-raw-sys v0.12.1 Checking foldhash v0.1.5 Checking datafusion-doc v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/doc) Checking tracing v0.1.44 Checking hashbrown v0.15.5 Checking walkdir v2.5.0 Checking rand_chacha v0.9.0 Checking futures-executor v0.3.32 Checking url v2.5.8 Checking http v1.4.1 Checking fastrand v2.4.1 Checking hashbrown v0.14.5 Checking fixedbitset v0.5.7 Checking humantime v2.3.0 Checking object_store v0.13.2 Checking petgraph v0.8.3 Checking tempfile v3.27.0 Checking dashmap v6.2.1 Checking futures v0.3.32 Checking rand v0.9.4 Compiling datafusion-macros v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/macros) Checking datafusion-expr-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/expr-common) Checking datafusion-physical-expr-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-common) Checking datafusion-functions-aggregate-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common) Checking datafusion-functions-window-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window-common) Checking datafusion-expr v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/expr) Checking datafusion-physical-expr v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr) Checking datafusion-execution v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/execution) Documenting datafusion-functions-aggregate v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate) error[E0050]: method `merge_batch` has 5 parameters but the declaration in trait `datafusion_expr::GroupsAccumulator::merge_batch` has 4 --> /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate/src/approx_distinct.rs:684:9 | 684 | / &mut self, 685 | | values: &[ArrayRef], 686 | | group_indices: &[usize], ... | 689 | | total_num_groups: usize, | |_______________________________^ expected 4 parameters, found 5 | = note: `merge_batch` from trait: `fn(&mut Self, &[std::sync::Arc<(dyn arrow::array::Array + 'static)>], &[usize], usize) -> std::result::Result<(), datafusion_common::DataFusionError>` help: remove the extra parameter to match the trait | 688 - opt_filter: Option<&BooleanArray>, 689 - total_num_groups: usize, 688 + opt_filter: Option<&BooleanArray>, | For more information about this error, try `rustc --explain E0050`. error: could not document `datafusion-functions-aggregate` ----- error: failed to build rustdoc for crate datafusion-functions-aggregate v53.1.0 note: this is usually due to a compilation error in the crate, and is unlikely to be a bug in cargo-semver-checks note: the following command can be used to reproduce the error: cargo new --lib example && cd example && echo '[workspace]' >> Cargo.toml && cargo add --path /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate && cargo check && cargo doc Building datafusion-functions-aggregate-common v53.1.0 (current) Built [ 20.305s] (current) Parsing datafusion-functions-aggregate-common v53.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-functions-aggregate-common v53.1.0 (baseline) Built [ 20.839s] (baseline) Parsing datafusion-functions-aggregate-common v53.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-functions-aggregate-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.125s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 42.140s] datafusion-functions-aggregate-common Building datafusion-physical-plan v53.1.0 (current) Built [ 36.031s] (current) Parsing datafusion-physical-plan v53.1.0 (current) Parsed [ 0.126s] (current) Building datafusion-physical-plan v53.1.0 (baseline) Built [ 36.129s] (baseline) Parsing datafusion-physical-plan v53.1.0 (baseline) Parsed [ 0.127s] (baseline) Checking datafusion-physical-plan v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.549s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 74.046s] datafusion-physical-plan Building datafusion-spark v53.1.0 (current) error: running cargo-doc on crate 'datafusion-spark' failed with output: ----- Compiling proc-macro2 v1.0.106 Compiling unicode-ident v1.0.24 Compiling quote v1.0.45 Compiling libc v0.2.186 Checking cfg-if v1.0.4 Compiling autocfg v1.5.1 Compiling libm v0.2.16 Checking memchr v2.8.1 Compiling num-traits v0.2.19 Compiling zerocopy v0.8.50 Compiling syn v2.0.117 Compiling version_check v0.9.5 Compiling getrandom v0.3.4 Checking bytes v1.11.1 Checking once_cell v1.21.4 Checking foldhash v0.2.0 Checking itoa v1.0.18 Compiling serde_core v1.0.228 Checking equivalent v1.0.2 Checking allocator-api2 v0.2.21 Compiling zmij v1.0.21 Checking num-integer v0.1.46 Checking hashbrown v0.17.1 Compiling serde_json v1.0.150 Checking num-bigint v0.4.6 Checking indexmap v2.14.0 Checking stable_deref_trait v1.2.1 Checking iana-time-zone v0.1.65 Checking siphasher v1.0.3 Checking chrono v0.4.45 Checking phf_shared v0.12.1 Compiling ahash v0.8.12 Compiling chrono-tz v0.10.4 Checking phf v0.12.1 Compiling shlex v2.0.1 Compiling synstructure v0.13.2 Compiling jobserver v0.1.34 Checking arrow-schema v58.3.0 Compiling find-msvc-tools v0.1.9 Compiling cc v1.2.63 Checking num-complex v0.4.6 Checking pin-project-lite v0.2.17 Checking lexical-util v1.0.7 Compiling pkg-config v0.3.33 Compiling zerocopy-derive v0.8.50 Compiling zerofrom-derive v0.1.7 Compiling yoke-derive v0.8.2 Compiling zerovec-derive v0.11.3 Checking zerofrom v0.1.8 Checking yoke v0.8.3 Compiling displaydoc v0.2.6 Checking writeable v0.6.3 Checking futures-core v0.3.32 Checking zerovec v0.11.6 Checking smallvec v1.15.1 Checking futures-sink v0.3.32 Checking litemap v0.8.2 Checking zerotrie v0.2.4 Checking tinystr v0.8.3 Checking potential_utf v0.1.5 Checking icu_locale_core v2.2.0 Compiling zstd-sys v2.0.16+zstd.1.5.7 Checking utf8_iter v1.0.4 Compiling icu_properties_data v2.2.0 Compiling icu_normalizer_data v2.2.0 Checking icu_collections v2.2.0 Checking icu_provider v2.2.0 Checking lexical-write-integer v1.0.6 Checking lexical-parse-integer v1.0.6 Checking rand_core v0.9.5 Compiling semver v1.0.28 Checking lexical-parse-float v1.0.6 Compiling rustc_version v0.4.1 Checking lexical-write-float v1.0.6 Checking futures-channel v0.3.32 Compiling tokio-macros v2.7.0 Compiling futures-macro v0.3.32 Checking aho-corasick v1.1.4 Checking half v2.7.1 Checking ppv-lite86 v0.2.21 Checking arrow-buffer v58.3.0 Checking regex-syntax v0.8.10 Checking rand_chacha v0.9.0 Checking ryu v1.0.23 Checking slab v0.4.12 Checking arrow-data v58.3.0 Checking unicode-width v0.2.2 Checking bitflags v2.13.0 Compiling zstd-safe v7.2.4 Checking futures-io v0.3.32 Checking unicode-segmentation v1.13.3 Checking arrow-array v58.3.0 Compiling parking_lot_core v0.9.12 Checking futures-task v0.3.32 Checking futures-util v0.3.32 Checking regex-automata v0.4.14 Checking arrow-select v58.3.0 Checking comfy-table v7.2.2 Checking rand v0.9.4 Checking tokio v1.52.3 Checking arrow-ord v58.3.0 Checking lexical-core v1.0.6 Checking icu_normalizer v2.2.0 Checking icu_properties v2.2.0 Compiling flatbuffers v25.12.19 Checking atoi v2.0.0 Checking scopeguard v1.2.0 Compiling getrandom v0.4.2 Checking base64 v0.22.1 Checking arrow-cast v58.3.0 Checking idna_adapter v1.2.2 Checking lock_api v0.4.14 Checking twox-hash v2.1.2 Checking regex v1.12.3 Checking csv-core v0.1.13 Checking percent-encoding v2.3.2 Compiling thiserror v2.0.18 Checking csv v1.4.0 Checking form_urlencoded v1.2.2 Checking lz4_flex v0.13.1 Checking idna v1.1.0 Compiling thiserror-impl v2.0.18 Compiling tracing-attributes v0.1.31 Checking tracing-core v0.1.36 Checking simdutf8 v0.1.5 Checking either v1.16.0 Checking same-file v1.0.6 Checking walkdir v2.5.0 Checking itertools v0.14.0 Checking arrow-json v58.3.0 Checking tracing v0.1.44 Checking url v2.5.8 Checking arrow-csv v58.3.0 Checking arrow-string v58.3.0 Checking parking_lot v0.12.5 Checking arrow-arith v58.3.0 Checking arrow-row v58.3.0 Compiling async-trait v0.1.89 Checking http v1.4.1 Checking humantime v2.3.0 Checking typenum v1.20.1 Checking log v0.4.32 Checking object_store v0.13.2 Checking uuid v1.23.2 Compiling pin-project-internal v1.1.13 Checking hybrid-array v0.4.12 Compiling generic-array v0.14.7 Checking datafusion-doc v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/doc) Compiling crossbeam-utils v0.8.21 Checking pin-project v1.1.13 Checking foldhash v0.1.5 Compiling rustix v1.1.4 Checking hashbrown v0.15.5 Checking crypto-common v0.2.2 Checking block-buffer v0.12.0 Checking futures-executor v0.3.32 Checking fixedbitset v0.5.7 Checking linux-raw-sys v0.12.1 Checking const-oid v0.10.2 Checking petgraph v0.8.3 Checking zstd v0.13.3 Checking digest v0.11.3 Checking futures v0.3.32 Checking arrow-ipc v58.3.0 Checking fastrand v2.4.1 Checking hashbrown v0.14.5 Checking arrow v58.3.0 Checking datafusion-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/common) Checking cpufeatures v0.3.0 Compiling datafusion-macros v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/macros) Checking tempfile v3.27.0 Checking dashmap v6.2.1 Checking block-buffer v0.10.4 Checking crypto-common v0.1.7 Compiling blake3 v1.8.5 Checking subtle v2.6.1 Checking constant_time_eq v0.4.2 Checking digest v0.10.7 Checking arrayref v0.3.9 Checking arrayvec v0.7.6 Checking blake2 v0.10.6 Checking sha2 v0.11.0 Checking md-5 v0.11.0 Checking hex v0.4.3 Checking datafusion-common-runtime v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/common-runtime) Checking glob v0.3.3 Checking tokio-util v0.7.18 Compiling bigdecimal v0.4.10 Checking tokio-stream v0.1.18 Compiling crc32fast v1.5.0 Checking sha1 v0.11.0 Checking datafusion-expr-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/expr-common) Checking datafusion-physical-expr-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-common) Checking datafusion-functions-aggregate-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common) Checking datafusion-functions-window-common v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window-common) Checking datafusion-expr v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/expr) Checking datafusion-physical-expr v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr) Checking datafusion-execution v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/execution) Checking datafusion-functions v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions) Checking datafusion-functions-aggregate v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate) Checking datafusion-functions-window v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window) Checking datafusion-optimizer v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/optimizer) error[E0050]: method `merge_batch` has 5 parameters but the declaration in trait `datafusion_expr::GroupsAccumulator::merge_batch` has 4 --> /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate/src/approx_distinct.rs:684:9 | 684 | / &mut self, 685 | | values: &[ArrayRef], 686 | | group_indices: &[usize], ... | 689 | | total_num_groups: usize, | |_______________________________^ expected 4 parameters, found 5 | = note: `merge_batch` from trait: `fn(&mut Self, &[Arc<(dyn arrow::array::Array + 'static)>], &[usize], usize) -> Result<(), DataFusionError>` help: remove the extra parameter to match the trait | 688 - opt_filter: Option<&BooleanArray>, 689 - total_num_groups: usize, 688 + opt_filter: Option<&BooleanArray>, | Checking datafusion-physical-plan v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-plan) Checking datafusion-physical-expr-adapter v53.1.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-adapter) For more information about this error, try `rustc --explain E0050`. error: could not compile `datafusion-functions-aggregate` (lib) due to 1 previous error warning: build failed, waiting for other jobs to finish... error[E0061]: this method takes 3 arguments but 4 arguments were supplied --> /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/hash_table.rs:206:26 | 206 | self.accumulator.merge_batch( | ^^^^^^^^^^^ ... 209 | None, | ---- unexpected argument #3 of type `Option<_>` | note: method defined here --> /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/groups_accumulator.rs:190:8 | 190 | fn merge_batch( | ^^^^^^^^^^^ help: remove the extra argument | 208 - group_indices, 209 - None, 208 + group_indices, | For more information about this error, try `rustc --explain E0061`. error: could not compile `datafusion-physical-plan` (lib) due to 1 previous error ----- error: failed to build rustdoc for crate datafusion-spark v53.1.0 note: this is usually due to a compilation error in the crate, and is unlikely to be a bug in cargo-semver-checks note: the following command can be used to reproduce the error: cargo new --lib example && cd example && echo '[workspace]' >> Cargo.toml && cargo add --path /home/runner/work/datafusion/datafusion/datafusion/spark --features core,datafusion,default && cargo check && cargo doc error: aborting due to failure to build rustdoc for crate datafusion v53.1.0 ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
