jayzhan211 commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1701119341
##########
datafusion/expr/src/test/function_stub.rs:
##########
@@ -291,6 +291,180 @@ impl AggregateUDFImpl for Count {
}
}
+create_func!(Min, min_udaf);
+
+pub fn min(expr: Expr) -> Expr {
+ Expr::AggregateFunction(AggregateFunction::new_udf(
+ min_udaf(),
+ vec![expr],
+ false,
+ None,
+ None,
+ None,
+ ))
+}
+
+/// Testing stub implementation of Min aggregate
+pub struct Min {
+ signature: Signature,
+ aliases: Vec<String>,
+}
+
+impl std::fmt::Debug for Min {
+ fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
+ f.debug_struct("Min")
+ .field("name", &self.name())
+ .field("signature", &self.signature)
+ .finish()
+ }
+}
+
+impl Default for Min {
+ fn default() -> Self {
+ Self::new()
+ }
+}
+
+impl Min {
+ pub fn new() -> Self {
+ Self {
+ aliases: vec!["min".to_string()],
+ signature: Signature::variadic_any(Volatility::Immutable),
+ }
+ }
+}
+
+impl AggregateUDFImpl for Min {
+ fn as_any(&self) -> &dyn std::any::Any {
+ self
+ }
+
+ fn name(&self) -> &str {
+ "MIN"
+ }
+
+ fn signature(&self) -> &Signature {
+ &self.signature
+ }
+
+ fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
+ Ok(DataType::Int64)
+ }
+
+ fn state_fields(&self, _args: StateFieldsArgs) -> Result<Vec<Field>> {
+ not_impl_err!("no impl for stub")
+ }
+
+ fn accumulator(&self, _acc_args: AccumulatorArgs) -> Result<Box<dyn
Accumulator>> {
+ not_impl_err!("no impl for stub")
+ }
+
+ fn aliases(&self) -> &[String] {
+ &self.aliases
+ }
+
+ fn create_groups_accumulator(
+ &self,
+ _args: AccumulatorArgs,
+ ) -> Result<Box<dyn GroupsAccumulator>> {
+ not_impl_err!("no impl for stub")
+ }
+
+ fn reverse_expr(&self) -> ReversedUDAF {
+ ReversedUDAF::Identical
+ }
+ fn is_descending(&self) -> Option<bool> {
+ Some(false)
+ }
+}
+
+create_func!(Max, max_udaf);
+
+pub fn max(expr: Expr) -> Expr {
+ Expr::AggregateFunction(AggregateFunction::new_udf(
+ max_udaf(),
+ vec![expr],
+ false,
+ None,
+ None,
+ None,
+ ))
+}
+
+/// Testing stub implementation of MAX aggregate
+pub struct Max {
+ signature: Signature,
+ aliases: Vec<String>,
+}
+
+impl std::fmt::Debug for Max {
+ fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
+ f.debug_struct("Min")
Review Comment:
this should be "Max"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
