alamb opened a new pull request, #11005: URL: https://github.com/apache/datafusion/pull/11005
## Which issue does this PR close? Part of https://github.com/apache/datafusion/issues/5637 Closes #. ## Rationale for this change When profiling on main these functions show up many times <img width="1309" alt="Screenshot 2024-06-19 at 11 13 16 AM" src="https://github.com/apache/datafusion/assets/490673/f31d92f6-3021-4817-9469-f540ae981b43";> ## What changes are included in this PR? Changes Mark the functions as `#[inline(always)]` - I think they are not inlined without the `#inline` attribute as they are in different crates This makes the profiles much easier to read and understand: <img width="1728" alt="Screenshot 2024-06-19 at 10 39 30 AM" src="https://github.com/apache/datafusion/assets/490673/df631763-1e26-42ca-ba1a-90650ce92bd9";> ## Are these changes tested? Functionally by exisitng tests Performance: (performance measurements in progress) Code size: I also made sure this didn't bloat the binary size: ```shell cd datafusion-cli cargo build --release ``` Before this PR: TODO After this PR: TODO ## Are there any user-facing changes? Hopefuly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
