jeffreyssmith2nd commented on PR #11755:
URL: https://github.com/apache/datafusion/pull/11755#issuecomment-2261419159
> It seems somewhat awkward to add a "type" of metric that is logically the
same bug just differs in aggregation behavior
I don't necessarily disagree with this, but where would the custom
aggregation function live/how would it be used? There are multiple places that
`MetricValue::aggregate` is called.
https://github.com/apache/datafusion/blob/02a9812745406b9cc00c04f9d870b23c4b3c4947/datafusion/physical-plan/src/metrics/mod.rs#L246
https://github.com/apache/datafusion/blob/02a9812745406b9cc00c04f9d870b23c4b3c4947/datafusion/physical-plan/src/metrics/mod.rs#L283
https://github.com/apache/datafusion/blob/02a9812745406b9cc00c04f9d870b23c4b3c4947/datafusion/physical-plan/src/metrics/mod.rs#L289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
