athlcode commented on code in PR #21720:
URL: https://github.com/apache/datafusion/pull/21720#discussion_r3311815062
##########
datafusion/common/src/config.rs:
##########
@@ -1461,6 +1508,24 @@ impl<'a> TryFrom<&'a FormatOptions> for
arrow::util::display::FormatOptions<'a>
}
}
+config_namespace! {
Review Comment:
Looked into it, no existing precedent for feature-gating a top-level
'ConfigOptions' namespace. parquet_encryption is the only #[cfg] user in
config.rs and it gates fields-within-a-struct, not the struct's registration.
##########
datafusion/common/src/config.rs:
##########
@@ -1461,6 +1508,24 @@ impl<'a> TryFrom<&'a FormatOptions> for
arrow::util::display::FormatOptions<'a>
}
}
+config_namespace! {
Review Comment:
Looked into it, no existing precedent for feature-gating a top-level
ConfigOptions namespace. parquet_encryption is the only #[cfg] user in
config.rs and it gates fields-within-a-struct, not the struct's registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
